Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

[Christophe Leroy]

Should this be applied by Bjorn as most recent changes to that file ?


Le 14/06/2022 à 12:12, Andrew Donnellan a écrit :
> On Sun, 2022-06-05 at 10:00 +0400, Miaoqian Lin wrote:
>> of_get_next_parent() returns a node pointer with refcount
>> incremented,
>> we should use of_node_put() on it when not need anymore.
>> This function only calls of_node_put() in normal path,
>> missing it in the error path.
>> Add missing of_node_put() to avoid refcount leak.
>>
>> Fixes: f24be42aab37 ("cxl: Add psl9 specific code")
>> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> 
> Thanks!
> 
> Acked-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>
> 
>> ---
>>   drivers/misc/cxl/pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
>> index 3de0aea62ade..62385a529d86 100644
>> --- a/drivers/misc/cxl/pci.c
>> +++ b/drivers/misc/cxl/pci.c
>> @@ -387,6 +387,7 @@ int cxl_calc_capp_routing(struct pci_dev *dev,
>> u64 *chipid,
>>          rc = get_phb_index(np, phb_index);
>>          if (rc) {
>>                  pr_err("cxl: invalid phb index\n");
>> +               of_node_put(np);
>>                  return rc;
>>          }
>>   
> 
>