Re: [PATCH 3/3] can: m_can: pci: add missing m_can_class_free_dev() in probe/remove methods

From: Jarkko Nikula
Date: Mon Nov 14 2022 - 10:03:50 EST


On 11/11/22 14:11, Zhang Changzhong wrote:
In m_can_pci_remove() and error handling path of m_can_pci_probe(),
m_can_class_free_dev() should be called to free resource allocated by
m_can_class_allocate_dev(), otherwise there will be memleak.

Fixes: cab7ffc0324f ("can: m_can: add PCI glue driver for Intel Elkhart Lake")
Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
---
drivers/net/can/m_can/m_can_pci.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

Reviewed-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>