Re: nbd: please don't spawn 16 threads when nbd is not even in use

From: Yu Kuai
Date: Thu Nov 24 2022 - 06:18:11 EST


Hi,

在 2022/11/24 18:06, Pavel Machek 写道:

Can we get that reverted?

That is rather obscure bug (how many GFP_KERNEL failures do you
normally see?) and it costs, dunno, 100KB? of unswappable memory.


No, I don't think that can be reverted. Introduce a BUG just to save
some memory sounds insane.

If you really want to do this. I think the right thing to do is to move
the allocation of recv_workq back to start device, and also fix the
problem properly.

Thanks,
Kuai
Best regards,
Pavel