Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi

[王洪辉]

Ok!

Thanks,
Best Regards!

Wang Honghui

  ------------------ Original ------------------From:  "Sudeep Holla"<sudeep.holla@xxxxxxx>;Date:  Thu, Nov 24, 2022 07:15 PMTo:  "Wang Honghui"<honghui.wang@xxxxxxxxxxx>; Cc:  "Cristian Maruss"<cristian.marussi@xxxxxxx>; "linux-arm-kernel"<linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; "linux-kernel"<linux-kernel@xxxxxxxxxxxxxxx>; Subject:  Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi On Thu, Nov 24, 2022 at 05:59:47PM +0800, Wang Honghui wrote:> Rev last modify to support acpi> > Signed-off-by: Wang Honghui <honghui.wang@xxxxxxxxxxx>> --->  drivers/firmware/arm_scpi.c | 4 ++++>  1 file changed, 4 insertions(+)> > diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c> index e2e90dcc38bd..aca0a9780c12 100644> --- a/drivers/firmware/arm_scpi.c> +++ b/drivers/firmware/arm_scpi.c> @@ -908,7 +908,9 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {> { }>  };>  > +#ifdef CONFIG_PHYTIUM_MBOX>  extern struct mbox_chan *phytium_mbox_request_channel(struct mbox_client *cl);> +#endifI have already NACK the approach you have taken for SCPI + ACPI. Just forgotto mention SCPI is old and deprecated protocol and SCMI replaced it. Youmuch be using that if possible.Anyways, this kind of #ifdeffery is not allowed in any generic code even ifI agreed with the approach. So please don't change the code in such a way.-- Regards,Sudeep