Re: [PATCH 3/3] hwmon: (pmbus/core): Implement IRQ support

[Guenter Roeck]

On 11/24/22 00:56, Naresh Solanki wrote:
> Hi Guenter,
>
> On 22-11-2022 10:32 pm, Guenter Roeck wrote:
> > On 11/22/22 05:50, Naresh Solanki wrote:
> > > From: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > >
> > > Implement IRQ support to monitor PMBUS regulator events.
> > >
> > > Signed-off-by: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > > Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>
> >
> > Adding a PMBus interrupt handler should be generic and also handle hwmon
> > specific events. It should report any status changes as sysfs attribute
> > notifications.
> This handler scope is to address regulator faults.

Maybe that is the use case from your perspective, but this is primarily
a hardware monitoring driver and needs to primarily serve its hardware
monitoring functionality.

Guenter