Re: [PATCH printk v2 1/7] printk: Move buffer size defines
From: John Ogness
Date: Thu Nov 24 2022 - 15:21:35 EST
On 2022-11-24, Petr Mladek <pmladek@xxxxxxxx> wrote:
> The motivation is that only thread/atomic consoles would need
> the console-specific buffer. The other consoles might share
> the global one.
I understand what you are saying. I will change it to a pointer and
assign it to an internal shared global static buffer on
register_console(). Then we can keep the size defines private.
For the upcoming thread/atomic consoles, I will setup the sprint-buffers
differently.
> Also the atomic consoles would need these buffers for each context.
> It might be even more useful to allocate them dynamically.
Yes, atomic consoles need dedicated per-console, per-cpu, per-context
buffers. Some of these are allocated dynamically. I will revisit this
with the idea of minimizing static buffers.
John