Re: [PATCH 3/3] arm_scpi: modify to support acpi

[Hanjun Guo]

On 2022/11/24 19:10, Sudeep Holla wrote:
> Hi Wang,
>
> On Thu, Nov 24, 2022 at 03:09:31PM +0800, Wang Honghui wrote:
> > arm_scpi: modify to support acpi
>
> 1. The commit message is pretty useless. I don't get the complete picture
>     of why you need this change or what you are trying to do in this change.
>
> 2. I am unable to see the series as a whole, just have 2 versions of 3/3
>     in my inbox.
>
> 3. This is not the correct way to use SCPI or mailbox in ACPI. You need
>     to use PCC and PCC OpRegion to achieve what you want. The whole SCPI
>     protocol details gets abstracted in the firmware(ACPI ASL)

Agreed, using PCC for ARM SCPI support, not some self-defined bindings.
If you have any issue to support SCPI in your platform, we can add the
support in the ACPI spec first, but from what I read from the ACPI spec,
the PCC or PCC OpRegion can support SPCI well, let me know if any
issues.

Thanks
Hanjun