[PATCH v2 0/2] x86/asm/bitops: optimize fls functions for constant expressions

From: Vincent Mailhol
Date: Thu Nov 24 2022 - 21:33:59 EST


The compilers provide some builtin expression equivalent to the fls(),
__fls() and fls64() functions of the kernel.

The kernel's x86 implementation relies on assembly code. This assembly
code can not be folded when used with constant expressions.

This series replaces the kernel assembly by a builtin equivalent when
appropriate. It is a follow-up on this previous series:

https://lore.kernel.org/all/20220907090935.919-1-mailhol.vincent@xxxxxxxxxx/

in which I promised to also modify the fls() functions.

* Changelog *

v1 -> v2:

* [patch 1/2] add Reviewed-by: Nick Desaulniers tag.

* [patch 2/2] replace:
BUILD_BUG_ON(sizeof(unsigned long long) != sizeof(x));
by:
BUILD_BUG_ON(!__same_type(x, unsigned long long));
and slightly modify the commit description.

Vincent Mailhol (2):
x86/asm/bitops: Replace __fls() by its generic builtin implementation
x86/asm/bitops: Use __builtin_clz*() to evaluate constant expressions

arch/x86/include/asm/bitops.h | 70 ++++++++++++++++++++---------------
1 file changed, 40 insertions(+), 30 deletions(-)

--
2.37.4