Re: [PATCH v2 2/3] PCI: armada8k: Add AC5 SoC support

[Thomas Petazzoni]

Hello!

On Fri, 25 Nov 2022 08:43:06 +0000
Vadym Kochan <vadym.kochan@xxxxxxxxxxx> wrote:

> [quote]
> this is not needed, as by the time Linux is loaded, link has already been established (by boot loaders)
> 
> So this code is not needed.
> [/quote]

Not ideal to rely on the bootloader for this sort of initialization,
and if we want to do this change, perhaps it should be done in another
patch.

But again, the fact that "it works for Marvell because their vendor
U-Boot does the right thing prior to loading Linux" is not really a
very solid argument to drop kernel code :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com