Re: [PATCH 2/3] powerpc/book3e: remove #include <generated/utsrelease.h>
From: Thomas Weißschuh
Date: Sat Nov 26 2022 - 09:07:40 EST
On 2022-11-26 07:36+0000, Christophe Leroy wrote:
> Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit :
>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include <generated/compile.h>")
>> removed the usage of the define UTS_VERSION but forgot to drop the
>> include.
>
> What about:
> arch/powerpc/platforms/52xx/efika.c
> arch/powerpc/platforms/amigaone/setup.c
> arch/powerpc/platforms/chrp/setup.c
> arch/powerpc/platforms/powermac/bootx_init.c
>
> I believe you can do a lot more than what you did in your series.
The commit messages are wrong.
They should have said UTS_RELEASE instead of UTS_VERSION.
Could the maintainers fix this up when applying?
I also changed it locally so it will be fixed for v2.
> List of files using UTS_VERSION :
>
> $ git grep -l UTS_VERSION
> [..]
Thomas