Re: [PATCH 4/4] media: i2c: s5c73m3: switch to using gpiod API

[Linus Walleij]

On Sat, Nov 26, 2022 at 11:34 AM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> On 17/11/2022 10:06, Linus Walleij wrote:
> > On Tue, Nov 15, 2022 at 11:11 PM Dmitry Torokhov
> > <dmitry.torokhov@xxxxxxxxx> wrote:
> >
> >> This patch switches the driver away from legacy gpio/of_gpio API to
> >> gpiod API, and removes use of of_get_named_gpio_flags() which I want to
> >> make private to gpiolib.
> >>
> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> There are now two patches that do this switch to using the gpiod API:
> this one, and one from you:

Ooops we stepped on each others' toes again. Dmitry & I really like
to fix these drivers :D sorry about that.

> https://patchwork.linuxtv.org/project/linux-media/patch/20221108100604.1500909-1-linus.walleij@xxxxxxxxxx/
>
> Any preference?

Not really, take the one you like best, they look functionally equivalent to me,
just slightly different stylistic choices.

Yours,
Linus Walleij