Re: [PATCH v4 1/2] dt-bindings: gce: add gce header file for mt8188

[Krzysztof Kozlowski]

On 24/11/2022 08:55, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@xxxxxxxxxxxx>

Subject: dt-bindings: mailbox: .......


> 
> add gce header file to define the gce thread priority, gce subsys id,

Start with capital letter. gce->GCE, right? So use capitals for acronym
and also explain what that acronym mean.

> event and constant for mt8188.>
> Signed-off-by: Elvis Wang <Elvis.Wang@xxxxxxxxxxxx>
> ---
>  .../dt-bindings/mailbox/mediatek,mt8188-gce.h | 966 ++++++++++++++++++
>  1 file changed, 966 insertions(+)
>  create mode 100644 include/dt-bindings/mailbox/mediatek,mt8188-gce.h
> 

(...)

> +#define CMDQ_SYNC_TOKEN_DISP_VA_START			1012
> +#define CMDQ_SYNC_TOKEN_DISP_VA_END			1013

One blank line here.

> +#endif

With all above changes:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof