Re: [RFC PATCH v2] KVM: x86/mmu: replace BUG() with KVM_BUG() in shadow mmu
From: Mingwei Zhang
Date: Sun Nov 27 2022 - 18:48:16 EST
On Wed, Nov 23, 2022 at 5:17 PM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> > v1 -> v2:
> > - compile test the code.
> > - fill KVM_BUG() with kvm_get_running_vcpu()->kvm
>
> Nope, the zapping code paths will run often with no running vCPU, for
> example drop_parent_pte <- kvm_mmu_unlink_parents <-
> __kvm_mmu_prepare_zap_page <- kvm_zap_obsolete_pages <-
> kvm_mmu_zap_all_fast <- kvm_mmu_invalidate_zap_pages_in_memslot <-
> kvm_page_track_flush_slot <- kvm_arch_flush_shadow_memslot <-
> kvm_invalidate_memslot <- ioctl(KVM_SET_USER_MEMORY_REGION).
>
> Paolo
Make sense. Will plumb through the kvm parameter in the next version.