Re: [PATCH 001/606] tpm: st33zp24: Convert to Convert to i2c's .probe_new()
From: Jarkko Sakkinen
Date: Sun Nov 27 2022 - 20:15:05 EST
On Fri, Nov 18, 2022 at 11:35:35PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/char/tpm/st33zp24/i2c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c
> index 614c7d8ed84f..0cd614933b4a 100644
> --- a/drivers/char/tpm/st33zp24/i2c.c
> +++ b/drivers/char/tpm/st33zp24/i2c.c
> @@ -101,8 +101,7 @@ static const struct st33zp24_phy_ops i2c_phy_ops = {
> * @return: 0 in case of success.
> * -1 in other case.
> */
> -static int st33zp24_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int st33zp24_i2c_probe(struct i2c_client *client)
> {
> struct st33zp24_i2c_phy *phy;
>
> @@ -167,7 +166,7 @@ static struct i2c_driver st33zp24_i2c_driver = {
> .of_match_table = of_match_ptr(of_st33zp24_i2c_match),
> .acpi_match_table = ACPI_PTR(st33zp24_i2c_acpi_match),
> },
> - .probe = st33zp24_i2c_probe,
> + .probe_new = st33zp24_i2c_probe,
> .remove = st33zp24_i2c_remove,
> .id_table = st33zp24_i2c_id
> };
> --
> 2.38.1
>
Acked-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
BR, Jarkko