RE: [PATCH v3 00/11] RTW88: Add support for USB variants

[Ping-Ke Shih]

> -----Original Message-----
> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Sent: Tuesday, November 22, 2022 10:52 PM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Neo Jou <neojou@xxxxxxxxx>; Hans Ulli Kroll <linux@xxxxxxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>;
> Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>;
> kernel@xxxxxxxxxxxxxx; Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; Alexander Hochbaum <alex@xxxxxxxxxx>;
> Da Xue <da@libre.computer>; Bernie Huang <phhuang@xxxxxxxxxxx>; Viktor Petrenko <g0000ga@xxxxxxxxx>;
> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Subject: [PATCH v3 00/11] RTW88: Add support for USB variants
> 
> This is the third round of adding support for the USB variants to the
> RTW88 driver. There are a few changes to the last version which make it
> worth looking at this version.
> 
> First of all RTL8723du and RTL8821cu are tested working now. The issue
> here was that the txdesc checksum calculation was wrong. I found the
> correct calculation in various downstream drivers found on github.
> 
> The second big issue was that TX packet aggregation was wrong. When
> aggregating packets each packet start has to be aligned to eight bytes.
> The necessary alignment was added to the total URB length before
> checking if there is another packet to aggregate, so the URB length
> included that padding after the last packet, which is wrong.  Fixing
> this makes the driver work much more reliably.
> 

Thanks for your finding and fixes on this driver. I have reviewed this 
patchset and written some comments. No big problem.


> 
> Sascha Hauer (11):
>   rtw88: print firmware type in info message
>   rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held
>   rtw88: Drop rf_lock
>   rtw88: Drop h2c.lock
>   rtw88: Drop coex mutex
>   rtw88: iterate over vif/sta list non-atomically
>   rtw88: Add common USB chip support
>   rtw88: Add rtw8821cu chipset support
>   rtw88: Add rtw8822bu chipset support
>   rtw88: Add rtw8822cu chipset support
>   rtw88: Add rtw8723du chipset support

Please use "wifi: rtw88: " as prefix in next version.

--
Ping-Ke