RE: [PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings

[Goh, Wei Sheng]

Hi,

> -----Original Message-----
> From: Lobakin, Alexandr <alexandr.lobakin@xxxxxxxxx>
> Sent: Saturday, 26 November, 2022 12:02 AM
> To: Goh, Wei Sheng <wei.sheng.goh@xxxxxxxxx>
> Cc: Lobakin, Alexandr <alexandr.lobakin@xxxxxxxxx>; Giuseppe Cavallaro
> <peppe.cavallaro@xxxxxx>; Alexandre Torgue <alexandre.torgue@xxxxxx>;
> Jose Abreu <joabreu@xxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>;
> Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo Abeni <pabeni@xxxxxxxxxx>; Maxime Coquelin
> <mcoquelin.stm32@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-stm32@st-md-
> mailman.stormreply.com; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>;
> Ong, Boon Leong <boon.leong.ong@xxxxxxxxx>; Voon, Weifeng
> <weifeng.voon@xxxxxxxxx>; Tan, Tee Min <tee.min.tan@xxxxxxxxx>; Ahmad
> Tarmizi, Noor Azura <noor.azura.ahmad.tarmizi@xxxxxxxxx>; Looi, Hong Aun
> <hong.aun.looi@xxxxxxxxx>
> Subject: Re: [PATCH net v4] net: stmmac: Set MAC's flow control register to
> reflect current settings
> 
> From: "Goh, Wei Sheng" <wei.sheng.goh@xxxxxxxxx>
> Date: Wed, 23 Nov 2022 18:51:10 +0800
> 
> > Currently, pause frame register GMAC_RX_FLOW_CTRL_RFE is not updated
> > correctly when 'ethtool -A <IFACE> autoneg off rx off tx off' command
> > is issued. This fix ensures the flow control change is reflected
> > directly in the GMAC_RX_FLOW_CTRL_RFE register.
> 
> Any particular reason why you completely ignored by review comments to the
> v3[0]? I'd like to see them fixed or at least replied.
> 
> >
> > Fixes: 46f69ded988d ("net: stmmac: Use resolved link config in
> > mac_link_up()")
> > Cc: <stable@xxxxxxxxxxxxxxx> # 5.10.x
> > Signed-off-by: Goh, Wei Sheng <wei.sheng.goh@xxxxxxxxx>
> > Signed-off-by: Noor Azura Ahmad Tarmizi
> > <noor.azura.ahmad.tarmizi@xxxxxxxxx>
> > ---
> > V3 -> V4: Fix commit message and incorrect insertions(+) value
> > V2 -> V3: Removed value assign for 'flow' in else statement based on
> > review comments
> > V1 -> V2: Removed needless condition based on review comments
> >
> >  drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |  2 ++
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++++++++++--
> >  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> [...]
> 
> > --
> > 2.17.1
> 
> [0] https://lore.kernel.org/netdev/20221123180947.488302-1-
> alexandr.lobakin@xxxxxxxxx
> 
> Thanks,
> Olek

Due to v4 is being accepted. Therefore I will submit a new patch to address your review comments.
Thanks and appreciate your effort for reviewing my patch.