Re: [PATCH] selftests/tls: Fix tls selftests dependency to correct algorithm
From: Tianjia Zhang
Date: Mon Nov 28 2022 - 02:40:23 EST
On 11/28/22 3:25 PM, Hangbin Liu wrote:
On Mon, Nov 28, 2022 at 03:14:16PM +0800, Tianjia Zhang wrote:
Hi Hangbin,
On 11/27/22 8:17 PM, Hangbin Liu wrote:
On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote:
Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves
the SM3 and SM4 stand-alone library and the algorithm implementation for
the Crypto API into the same directory, and the corresponding relationship
of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone
library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the
algorithm implementation for the Crypto API. Therefore, it is necessary
for this module to depend on the correct algorithm.
Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory")
Cc: Jason A. Donenfeld <Jason@xxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx # v5.19+
Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
---
tools/testing/selftests/net/config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index ead7963b9bf0..bd89198cd817 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m
CONFIG_NET_ACT_MIRRED=m
CONFIG_BAREUDP=m
CONFIG_IPV6_IOAM6_LWTUNNEL=y
-CONFIG_CRYPTO_SM4=y
+CONFIG_CRYPTO_SM4_GENERIC=y
CONFIG_AMT=m
--
2.24.3 (Apple Git-128)
Looks the issue in this discuss
https://lore.kernel.org/netdev/Y3c9zMbKsR+tcLHk@Laptop-X1/
related to your fix.
Thanks for your information, it is indeed the same issue.I don’t know if
there is a patch to fix it. If not, can this patch solve this issue? If
so, can I add Reported-by or Tested-by tag?
Feel free to add Reported-by flag. I can't test this unless the patch merged
to upstream.
Thanks, I will send a v2 patch as soon as possible.
Tianjia