Re: [PATCH net-next 2/2] bnxt: Use generic HBH removal helper in tx path
From: Leon Romanovsky
Date: Mon Nov 28 2022 - 04:55:07 EST
On Wed, Nov 23, 2022 at 05:41:59PM +0100, Alexander Lobakin wrote:
> From: Coco Li <lixiaoyan@xxxxxxxxxx>
> Date: Tue, 22 Nov 2022 15:27:40 -0800
>
> > Eric Dumazet implemented Big TCP that allowed bigger TSO/GRO packet sizes
> > for IPv6 traffic. See patch series:
> > 'commit 89527be8d8d6 ("net: add IFLA_TSO_{MAX_SIZE|SEGS} attributes")'
> >
> > This reduces the number of packets traversing the networking stack and
> > should usually improves performance. However, it also inserts a
> > temporary Hop-by-hop IPv6 extension header.
> >
> > Using the HBH header removal method in the previous path, the extra header
> > be removed in bnxt drivers to allow it to send big TCP packets (bigger
> > TSO packets) as well.
> >
> > If bnxt folks could help with testing this patch on the driver (as I
> > don't have access to one) that would be wonderful. Thank you!
> >
> > Tested:
> > Compiled locally
>
> Please mark "potential" patches with 'RFC'. Then, if/when you get a
> 'Tested-by:', you can spin a "true" v1.
We are getting ton of patches which are "compiled-only".
I won't be such strict with them as long as they stated clearly about it.
Thanks