Re: [PATCH v3 1/5] vfio/migration: Add debugfs to live migration driver

[Jason Gunthorpe]

On Mon, Nov 28, 2022 at 11:11:56AM +0800, Longfang Liu wrote:

> @@ -119,6 +132,9 @@ struct vfio_migration_ops {
>  				   enum vfio_device_mig_state *curr_state);
>  	int (*migration_get_data_size)(struct vfio_device *device,
>  				       unsigned long *stop_copy_length);
> +	int (*migration_get_data)(struct vfio_device *device, char *buffer);
> +	int (*migration_get_attr)(struct vfio_device *device, char *buffer);
> +	int (*migration_debug_operate)(struct vfio_device *device,
>  				   unsigned int cmd);

Please don't do wrappers like this, give the variant driver a chance
to create its own files natively under the debugfs directory

Jason