Re: [PATCH v1 1/2] dt-bindings: leds: add binding for aw200xx

[Martin Kurbanov]

Hi. Thank you for quick reply. 

On 25.11.2022 11:29, Krzysztof Kozlowski wrote:
>> +
>> +  imax:
>> +    maxItems: 1
>> +    description:
>> +      Maximum supply current, see dt-bindings/leds/leds-aw200xx.h
> 
> No. Use existing properties from common.yaml. This looks like
> led-max-microamp and it is per LED, not per entire device.

The AW200XX LED chip does not support imax setup per led.
Imax is the global parameter over the all leds. I suppose, it's better
to add vendor prefix or take minimum from all subnodes?
How do you think?


>> +/* Global max current (IMAX) */
>> +#define AW200XX_IMAX_3_3MA  8
>> +#define AW200XX_IMAX_6_7MA  9
> 
> No. Bindings are not for storing register constants. Feel free to store
> here IDs (ID start from 0 or 1 and is incremented by 1)... but how the
> IMAX even matches any need for "ID"?

IMAX can be chosen from the predefined values in the
datasheet (10mA, 20mA, etc). Do you mean the IMAX should be round down
to nearest supported value in the driver?

-- 
Best Regards,
Kurbanov Martin