Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c

[Paolo Bonzini]

On 11/28/22 18:45, Steven Rostedt wrote:
> > > If you are sure <asm/ftrace.h> is never included from asm-offsets.c,
> > > remove #ifndef COMPILE_OFFSETS too.
> > It is never included from asm-offsets.c but it is still used by
> > kvm-asm-offsets.c:
> > https://elixir.bootlin.com/linux/v6.1-rc7/source/arch/x86/kvm/kvm-asm-offsets.c#L7
> IIRC, the reason for adding that was because that logic was screwing up
> asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
>
> This is one of those cases I wish I commented that code better :-/

I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all.

Paolo