Re: [PATCH v4 1/2] EDAC/qcom: Get rid of hardcoded register offsets

[Manivannan Sadhasivam]

On Mon, Nov 28, 2022 at 01:16:53PM +0100, Borislav Petkov wrote:
> On Wed, Nov 16, 2022 at 08:03:51PM +0530, Manivannan Sadhasivam wrote:
> > The LLCC EDAC register offsets varies between each SoC. Hardcoding the
> > register offsets won't work and will often result in crash due to
> > accessing the wrong locations.
> > 
> > Hence, get the register offsets from the LLCC driver matching the
> > individual SoCs.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> >  drivers/edac/qcom_edac.c           | 116 ++++++++++++++---------------
> >  include/linux/soc/qcom/llcc-qcom.h |   6 --
> >  2 files changed, 58 insertions(+), 64 deletions(-)
> 
> It looks to me like this patch needs to go to stable?
> 

Well, yes but that would imply both LLCC and EDAC patches going together.
Splitting them will break the build, which is worse.

So I delibrately avoided CCing stable list. I'll ping them once both patches
are in mainline.

> Also, the Fixes tag should probably be:
> 
> Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
> 
> Yes, no?
> 

No. The actual breakage happened with, a6e9d7ef252c ("soc: qcom: llcc: Add
configuration data for SM8450 SoC"). I didn't add the fixes tag because, the
stable team might backport this patch automatically. And since the tag is not
present in the LLCC patch, it will break the build.

> Also, please explain to me how you've tested this patch if it doesn't
> even build?!
> 
> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/llcc-qcom.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
> make: *** [Makefile:1944: modpost] Error 2
> 
> I guess because CONFIG_QCOM_LLCC is =y in your config while I have
> CONFIG_QCOM_LLCC=m.
> 
> And I reported the same build error to you the last time. Did you not
> see it?
> 
> For the next version, you'd need to fix all possible Kconfig build
> errors before sending.
> 

Sorry, it is because I only tried building for ARM64 architecture. The error
you are seeing is for x86-64 and I could now reproduce it as well.

Will submit the next iteration including a fix for that.

Thanks,
Mani

> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

-- 
மணிவண்ணன் சதாசிவம்