Re: [net PATCH] dsa: lan9303: Correct stat name

[Florian Fainelli]

On 11/28/22 11:35, Jerry Ray wrote:
> Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

The Fixes: tag is supposed to come above your Signed-off-by, I don't 
know if the maintainers will fix that up manually or not, but in any case:

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

> This patch changes the reported ethtool statistics for the lan9303
> family of parts covered by this driver.
>
> The TxUnderRun statistic label is renamed to RxShort to accurately
> reflect what stat the device is reporting.  I did not reorder the
> statistics as that might cause problems with existing user code that
> are expecting the stats at a certain offset.
>
> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
> ---
>   drivers/net/dsa/lan9303-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
> index 438e46af03e9..80f07bd20593 100644
> --- a/drivers/net/dsa/lan9303-core.c
> +++ b/drivers/net/dsa/lan9303-core.c
> @@ -961,7 +961,7 @@ static const struct lan9303_mib_desc lan9303_mib[] = {
>   	{ .offset = LAN9303_MAC_TX_BRDCST_CNT_0, .name = "TxBroad", },
>   	{ .offset = LAN9303_MAC_TX_PAUSE_CNT_0, .name = "TxPause", },
>   	{ .offset = LAN9303_MAC_TX_MULCST_CNT_0, .name = "TxMulti", },
> -	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "TxUnderRun", },
> +	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "RxShort", },
>   	{ .offset = LAN9303_MAC_TX_64_CNT_0, .name = "Tx64Byte", },
>   	{ .offset = LAN9303_MAC_TX_127_CNT_0, .name = "Tx128Byte", },
>   	{ .offset = LAN9303_MAC_TX_255_CNT_0, .name = "Tx256Byte", },

--
Florian