Re: [PATCH v5 07/16] ufs: core: mcq: Calculate queue depth

From: Bart Van Assche
Date: Mon Nov 28 2022 - 15:33:14 EST


On 11/28/22 11:54, Asutosh Das wrote:
On Mon, Nov 28 2022 at 07:15 -0800, Manivannan Sadhasivam wrote:
On Tue, Nov 22, 2022 at 08:10:20PM -0800, Asutosh Das wrote:
+static inline int ufshcd_mcq_vops_get_hba_mac(struct ufs_hba *hba)

Again, no inline please.

It spits out the following warning for all files that include this header, when
inline is removed:
warning: 'ufshcd_mcq_vops_get_hba_mac' defined but not used [-Wunused-function]

My understanding is that the "no inline" rule applies to .c files only and also that functions defined in header files should be declared "static inline".

Thanks,

Bart.