Re: [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush() instead of call_rcu()

From: Paul E. McKenney
Date: Mon Nov 28 2022 - 16:39:39 EST


On Fri, Nov 25, 2022 at 04:11:26PM -0800, Bart Van Assche wrote:
> On 11/21/22 17:04, Paul E. McKenney wrote:
> > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > index 6995c89792300..634672e67c81f 100644
> > --- a/drivers/scsi/scsi_error.c
> > +++ b/drivers/scsi/scsi_error.c
> > @@ -312,7 +312,7 @@ void scsi_eh_scmd_add(struct scsi_cmnd *scmd)
> > * Ensure that all tasks observe the host state change before the
> > * host_failed change.
> > */
> > - call_rcu(&scmd->rcu, scsi_eh_inc_host_failed);
> > + call_rcu_flush(&scmd->rcu, scsi_eh_inc_host_failed);
> > }
>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

Thank you both, I will apply these on the next rebase.

Thanx, Paul