RE: [PATCH] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream()

[Prabhakar Mahadev Lad]

Hi Nathan,

Thank you for the patch.

> -----Original Message-----
> From: Nathan Chancellor <nathan@xxxxxxxxxx>
> Sent: 28 November 2022 06:16
> To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; Prabhakar
> Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>; Tom Rix <trix@xxxxxxxxxx>; linux-
> media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; llvm@xxxxxxxxxxxxxxx; patches@xxxxxxxxxxxxxxx;
> Nathan Chancellor <nathan@xxxxxxxxxx>
> Subject: [PATCH] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream()
> 
> Clang warns:
> 
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:445:7: error: variable 'ret' is used
> uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>                   if (ret)
>                       ^~~
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:475:9: note: uninitialized use occurs here
>           return ret;
>                 ^~~
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:445:3: note: remove the 'if' if its condition
> is always false
>                   if (ret)
>                   ^~~~~~~~
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:441:7: error: variable 'ret' is used
> uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>                   if (ret)
>                       ^~~
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:475:9: note: uninitialized use occurs here
>           return ret;
>                 ^~~
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:441:3: note: remove the 'if' if its condition
> is always false
>                   if (ret)
>                   ^~~~~~~~
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:431:9: note: initialize the variable 'ret' to
> silence this warning
>           int ret;
>                 ^
>                   = 0
>   2 errors generated.
> 
> ret is unnecessarily shadowed, meaning the assignments to ret within the first 'if (enable)' block are
> only applied to the inner scope, not the outer one as intended. Remove the shadowing to fix the
> warnings and make everything work correctly.
> 
> Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver")
> Link:
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClangBuiltLinux%2Flinux
> %2Fissues%2F1764&amp;data=05%7C01%7Cprabhakar.mahadev-
> lad.rj%40bp.renesas.com%7C76d2a49f939a46e8d15208dad1081ed7%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%
> 7C638052130064697087%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=fp%2F1JCtgKY8E6qVMRlLewVLYc9WDZ%2ByNtg6t%2BGqIUvk%3D&amp;reserved=
> 0
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 2 --
>  1 file changed, 2 deletions(-)
> 
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Prabhakar