RE: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the devlink_ops::info_get() callback optional

[Keller, Jacob E]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Vincent Mailhol
> Sent: Monday, November 28, 2022 4:06 PM
> To: Jiri Pirko <jiri@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; Jakub Kicinski
> <kuba@xxxxxxxxxx>
> Cc: Andrew Lunn <andrew@xxxxxxx>; Shijith Thotton <sthotton@xxxxxxxxxxx>;
> Simon Horman <simon.horman@xxxxxxxxxxxx>; Kurt Kanzenbach
> <kurt@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jerin Jacob
> <jerinj@xxxxxxxxxxx>; Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>; Ioana
> Ciornei <ioana.ciornei@xxxxxxx>; drivers@xxxxxxxxxxx; Linu Cherian
> <lcherian@xxxxxxxxxxx>; Florian Fainelli <f.fainelli@xxxxxxxxx>; Herbert Xu
> <herbert@xxxxxxxxxxxxxxxxxxx>; Leon Romanovsky <leon@xxxxxxxxxx>; linux-
> rdma@xxxxxxxxxxxxxxx; Shalom Toledo <shalomt@xxxxxxxxxxxx>; Srujana
> Challa <schalla@xxxxxxxxxxx>; Minghao Chi <chi.minghao@xxxxxxxxxx>; Hao
> Chen <chenhao288@xxxxxxxxxxxxx>; Guangbin Huang
> <huangguangbin2@xxxxxxxxxx>; Shannon Nelson <snelson@xxxxxxxxxxx>;
> intel-wired-lan@xxxxxxxxxxxxxxxx; Vadim Fedorenko <vadfed@xxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Yisen Zhuang <yisen.zhuang@xxxxxxxxxx>; Sunil
> Goutham <sgoutham@xxxxxxxxxxx>; Ariel Elior <aelior@xxxxxxxxxxx>; Ido
> Schimmel <idosch@xxxxxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>;
> Arnaud Ebalard <arno@xxxxxxxxxxxx>; Jiri Pirko <jiri@xxxxxxxxxxxx>; Michael
> Chan <michael.chan@xxxxxxxxxxxx>; Vincent Mailhol
> <mailhol.vincent@xxxxxxxxxx>; Petr Machata <petrm@xxxxxxxxxx>; Salil Mehta
> <salil.mehta@xxxxxxxxxx>; Dimitris Michailidis <dmichail@xxxxxxxxxxxx>;
> Manish Chopra <manishc@xxxxxxxxxxx>; Boris Brezillon
> <bbrezillon@xxxxxxxxxx>; oss-drivers@xxxxxxxxxxxx; Vadim Pasternak
> <vadimp@xxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; David S . Miller
> <davem@xxxxxxxxxxxxx>; Taras Chornyi <tchornyi@xxxxxxxxxxx>; hariprasad
> <hkelam@xxxxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx; Jonathan Lemon
> <jonathan.lemon@xxxxxxxxx>; Vladimir Oltean <olteanv@xxxxxxxxx>; Saeed
> Mahameed <saeedm@xxxxxxxxxx>; Geetha sowjanya <gakula@xxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the
> devlink_ops::info_get() callback optional
> 
> Some drivers only reported the driver name in their
> devlink_ops::info_get() callback. Now that the core provides this
> information, the callback became empty. For such drivers, just
> removing the callback would prevent the core from executing
> devlink_nl_info_fill() meaning that "devlink dev info" would not
> return anything.
> 
> Make the callback function optional by executing
> devlink_nl_info_fill() even if devlink_ops::info_get() is NULL.
> 
> N.B.: the drivers with devlink support which previously did not
> implement devlink_ops::info_get() will now also be able to report
> the driver name.
> 

Makes sense to me.

Thanks,
Jake