Re: [PATCH v1 00/26] net: dsa: microchip: stats64, fdb, error
From: Oleksij Rempel
Date: Tue Nov 29 2022 - 00:36:14 EST
On Mon, Nov 28, 2022 at 03:09:19PM -0800, Jacob Keller wrote:
>
>
> On 11/28/2022 3:59 AM, Oleksij Rempel wrote:
> > This patch series is a result of maintaining work on ksz8 part of
> > microchip driver. It includes stats64 and fdb support. Error handling.
> > Loopback fix and so on...
> >
> > Oleksij Rempel (26):
> > net: dsa: microchip: add stats64 support for ksz8 series of switches
> > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix port validation and VID
> > information
> > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix not complete fdb
> > extraction
> > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix time stamp extraction
> > net: dsa: microchip: ksz8: ksz8_fdb_dump: do not extract ghost entry
> > from empty table
> > net: dsa: microchip: ksz8863_smi: fix bulk access
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): remove timestamp support
> > net: dsa: microchip: make ksz8_r_dyn_mac_table() static
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): remove fid support
> > net: dsa: microchip: ksz8: refactor ksz8_fdb_dump()
> > net: dsa: microchip: ksz8: ksz8_fdb_dump: dump static MAC table
> > net: dsa: microchip: ksz8: move static mac table operations to a
> > separate functions
> > net: dsa: microchip: ksz8: add fdb_add/del support
> > net: dsa: microchip: KSZ88x3 fix loopback support
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): move main part of the
> > code out of if statement
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): use ret instead of rc
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): ksz: do not return EAGAIN
> > on timeout
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): return read/write error
> > if we got any
> > net: dsa: microchip: ksz8_r_dyn_mac_table(): use entries variable to
> > signal 0 entries
> > net: dsa: microchip: make ksz8_r_sta_mac_table() static
> > net: dsa: microchip: ksz8_r_sta_mac_table(): do not use error code for
> > empty entries
> > net: dsa: microchip: ksz8_r_sta_mac_table(): make use of error values
> > provided by read/write functions
> > net: dsa: microchip: make ksz8_w_sta_mac_table() static
> > net: dsa: microchip: ksz8_w_sta_mac_table(): make use of error values
> > provided by read/write functions
> > net: dsa: microchip: remove ksz_port:on variable
> > net: dsa: microchip: ksz8: do not force flow control by default
> >
>
>
> My understanding is that we typically limit series to 15 patches. Do you
> have some justification for why this goes over 15 and can't reasonably be
> split into two series?
>
> At a glance it seems like a bunch of smaller cleanups.
The previous patch set got request to do more clean ups:
https://lore.kernel.org/all/20221124101458.3353902-1-o.rempel@xxxxxxxxxxxxxx/
I need to show, there are already more patches in the queue.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |