Re: [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe()

[Vincent MAILHOL]

On Tue. 29 Nov. 2022 at 15:43, Wang Yufen <wangyufen@xxxxxxxxxx> wrote:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@xxxxxxxxxx>
> ---
>  drivers/usb/host/fhci-hcd.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..c8a1b98 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
>                                         NULL, i, GPIOD_OUT_LOW);
>
>                 if (IS_ERR(fhci->gpiods[i])) {
> -                       dev_err(dev, "incorrect GPIO%d: %ld\n",
> -                               i, PTR_ERR(fhci->gpiods[i]));
> +                       ret = PTR_ERR(fhci->gpiods[i]);
> +                       dev_err(dev, "incorrect GPIO%d: %d\n",
> +                               i, ret);

Nitpick: you do not need a new line. It fits the 80 characters limit very well.

Aside of that:
Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

>                         goto err_gpios;
>                 }
>                 if (!fhci->gpiods[i]) {
> --
> 1.8.3.1
>