Re: [PATCH net-next v2] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

[Vincent MAILHOL]

On Tue. 29 Nov. 2022 at 17:33, Jiri Pirko <jiri@xxxxxxxxxxx> wrote:
> Tue, Nov 29, 2022 at 04:14:06AM CET, mailhol.vincent@xxxxxxxxxx wrote:
> >As discussed in [1], abbreviating the bootloader to "bl" might not be
> >well understood. Instead, a bootloader technically being a firmware,
> >name it "fw.bootloader".
> >
> >Add a new macro to devlink.h to formalize this new info attribute name
> >and update the documentation.
> >
> >[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@xxxxxxxxxx/
> >
> >Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> >Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> >---
> >* Changelog *
> >
> >v1 -> v2:
> >
> >  * update the documentation as well.
> >  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@xxxxxxxxxx/
> >---
> > Documentation/networking/devlink/devlink-info.rst | 5 +++++
> > include/net/devlink.h                             | 2 ++
> > 2 files changed, 7 insertions(+)
> >
> >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
> >index 7572bf6de5c1..1242b0e6826b 100644
> >--- a/Documentation/networking/devlink/devlink-info.rst
> >+++ b/Documentation/networking/devlink/devlink-info.rst
> >@@ -198,6 +198,11 @@ fw.bundle_id
> >
> > Unique identifier of the entire firmware bundle.
> >
> >+fw.bootloader
> >+-------------
> >+
> >+Version of the bootloader.
> >+
> > Future work
> > ===========
> >
> >diff --git a/include/net/devlink.h b/include/net/devlink.h
> >index 074a79b8933f..2f552b90b5c6 100644
> >--- a/include/net/devlink.h
> >+++ b/include/net/devlink.h
> >@@ -621,6 +621,8 @@ enum devlink_param_generic_id {
> > #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE  "fw.roce"
> > /* Firmware bundle identifier */
> > #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID     "fw.bundle_id"
> >+/* Bootloader */
> >+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER    "fw.bootloader"
>
> You add it and don't use it. You should add only what you use.

I will use it in this series for the linux-can tree:
https://lore.kernel.org/netdev/20221126162211.93322-4-mailhol.vincent@xxxxxxxxxx/

If it is a problem to send this as a standalone patch, I will then
just add it to my series and have the patch go through the linux-can
tree.


Yours sincerely,
Vincent Mailhol