Re: [RFC PATCH V2 01/18] x86/sev: Pvalidate memory gab for decompressing kernel

[Borislav Petkov]

On Tue, Nov 29, 2022 at 10:42:48PM +0800, Tianyu Lan wrote:
> Thanks for your review. sev_snp_enabled() is used after sev_status
> was initialized in sev_enable() while pvalidate_for_startup_ 64() is
> called before sev_enable().

Then you're going to have to change the code so that sev_status is
initialized before you need it. And not break others in the process.

And lemme save you some time - I won't accept sloppy code. You need to
integrate the functionality you need in the code paths properly - not
bolt it on in complete disregard of the flow just because it is easier.

> This is for Linux direct boot mode and so it needs to do such check
> here.

I don't know what "Linux direct boot mode" is so until you define it
properly and explain everything in detail, this is not going anywhere.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette