Re: [PATCH v7 1/4] dt-bindings: hwmon: fan: Add fan binding to schema

[Naresh Solanki]

On 29-11-2022 09:27 pm, Krzysztof Kozlowski wrote:
> On 29/11/2022 16:46, Naresh Solanki wrote:
> > Hi Krzysztof,
> >
> > On 29-11-2022 01:42 pm, Krzysztof Kozlowski wrote:
> > > On 21/11/2022 13:29, Naresh Solanki wrote:
> > >
> > > > +  pulses-per-revolution:
> > > > +    description:
> > > > +      The number of pulse from fan sensor per revolution.
> > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > +
> > > > +  target-rpm:
> > > > +    description:
> > > > +      Target RPM the fan should be configured during driver probe.
> > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > +
> > > > +  pwms:
> > > > +    description:
> > > > +      PWM provider.
> > >
> > > Ah, so it is not a PWM provider by this FAN controller? A bit confusing
> > > description. Instead maybe:
> > > 	PWM signal for the fan
> > Sure.
> > > and do you expect more than one PWM for one fan?
> > One pwm per fan
>
> then:
>    maxItems: 1
Sure
> Best regards,
> Krzysztof
Regards,
Naresh