Re: [PATCH v3 2/2] spi: Add Socionext F_OSPI SPI flash controller driver

[Kunihiko Hayashi]

Hi Geert,

On 2022/11/30 1:49, Geert Uytterhoeven wrote:
> Hi Hayashi-san,
>
> On Thu, Nov 24, 2022 at 1:36 AM Kunihiko Hayashi
> <hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
> > Introduce Socionext F_OSPI controller driver. This controller is used to
> > communicate with slave devices such as SPI Flash memories. It supports
> > 4 slave devices and up to 8-bit wide bus, but supports master mode only.
> >
> > This driver uses spi-mem framework for SPI flash memory access, and
> > can only operate indirect access mode and single data rate mode.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
>
> Thanks for your patch, which is now commit 1b74dd64c8612619
> ("spi: Add Socionext F_OSPI SPI flash controller driver") in
> spi/for-next.

Thank you for your work.

> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -906,6 +906,15 @@ config SPI_SLAVE_MT27XX
> >            say Y or M here.If you are not sure, say N.
> >            SPI slave drivers for Mediatek MT27XX series ARM SoCs.
> >
> > +config SPI_SN_F_OSPI
> > +       tristate "Socionext F_OSPI SPI flash controller"
> > +       depends on OF && HAS_IOMEM
> > +       depends on SPI_MEM
>
> On which systems is this hardware block found?
> Perhaps this should depend on ARCH_UNIPHIER || COMPILE_TEST?

This IP doesn't depend on ARCH_UNIPHIER, so I expect that it can be widely
applied not only to ARCH_UNIPHIER.

If COMPILE_TEST is required, the dependency is like SPI_CADENCE_XSPI:
        depends on (OF || COMPILE_TEST) && HAS_IOMEM

Thank you,

---
Best Regards
Kunihiko Hayashi