Re: [External] Re: [PATCH v2 2/2] sched/core: Adjusting the order of scanning CPU
From: Vincent Guittot
Date: Wed Nov 30 2022 - 03:00:18 EST
On Wed, 30 Nov 2022 at 07:35, Hao Jia <jiahao.os@xxxxxxxxxxxxx> wrote:
>
>
>
> On 2022/11/14 Mel Gorman wrote:
> > On Wed, Oct 26, 2022 at 02:43:00PM +0800, Hao Jia wrote:
> >> When select_idle_capacity() starts scanning for an idle CPU, it starts
> >> with target CPU that has already been checked in select_idle_sibling().
> >> So we start checking from the next CPU and try the target CPU at the end.
> >> Similarly for task_numa_assign(), we have just checked numa_migrate_on
> >> of dst_cpu, so start from the next CPU. This also works for
> >> steal_cookie_task(), the first scan must fail and start directly
> >> from the next one.
> >>
> >> Signed-off-by: Hao Jia <jiahao.os@xxxxxxxxxxxxx>
> >
> > Test results in general look ok so
> >
> > Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> >
>
> Hi, Peter
> These two patches have been Acked-by Mel Gorman.
> If you have time, please review these two patches.
>
> Thanks,
> Hao