Re: [PATCH] IB/hfi1: switch to netif_napi_add()
From: Leon Romanovsky
Date: Wed Nov 30 2022 - 03:40:44 EST
On Tue, Nov 29, 2022 at 10:25:01AM +0000, cgel.zte@xxxxxxxxx wrote:
> From: Yang Yang <yang.yang29@xxxxxxxxxx>
>
> There is no need to use netif_napi_add_weight() when the weight argument
> is 64. See "net: drop the weight argument from netif_napi_add".
>
> Signed-off-by: Yang Yang <yang.yang29@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please send this patch as plain-text with git send-email.
It wasn't recorded in https://lore.kernel.org/linux-rdma/
Thanks
>
> diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> index 3dfa5aff2512..720d4c85c9c9 100644
> --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> @@ -216,7 +216,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
> * right now.
> */
> set_bit(NAPI_STATE_NO_BUSY_POLL, &rxq->napi.state);
> - netif_napi_add_weight(dev, &rxq->napi, hfi1_netdev_rx_napi, 64);
> + netif_napi_add(dev, &rxq->napi, hfi1_netdev_rx_napi);
> rc = msix_netdev_request_rcd_irq(rxq->rcd);
> if (rc)
> goto bail_context_irq_failure;
> --
> 2.25.1
>