Re: [RFC v1] hack: suspend: usb: option: add reset_resume callback

From: Oliver Neukum
Date: Wed Nov 30 2022 - 09:04:42 EST




On 30.11.22 13:15, Martin Kepplinger wrote:
Currently to be the same as resume(). This will just avoid re-enumeration
of the modem device on every system resume.

This exists only because the usb core will re-enumerate *any* device
whos' driver doesn't have reset_resume() implemented. A call trace:

Hi,

this is deeply problematic. Strictly speaking it introduces a bug.
By implementing reset_resume() you are telling the rest of the system
that all settings have survived the hibernation. That is likely wrong in
your case.

Regards
Oliver