Re: [PATCH v7 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order

From: Vitaly Wool
Date: Wed Nov 30 2022 - 10:23:20 EST


On Tue, Nov 29, 2022 at 4:54 PM Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> On Tue, Nov 29, 2022 at 11:03:45PM +0900, Sergey Senozhatsky wrote:
> > On (22/11/29 12:53), Vitaly Wool wrote:
> > > I think the amount of #ifdefs here becomes absolutely overwhelming.
> > > Not that zsmalloc code was very readable before, but now it is
> > > starting to look like a plain disaster.
> >
> > Presumably most of them will go away once LRU moved from
> > allocator to upper level.
>
> Yes consider it the "cut here" lines for refactoring the LRU into
> zswap, which we want to do next. They're not here to stay, and that
> work will remove a lot of duplication and complexity from all
> backends. So I hope it's acceptable as a transitionary state.

I see, thanks for the explanation.

~Vitaly