Re: [PATCH v4 4/5] selftests/resctrl: Cleanup properly when an error occurs in CAT test

From: Reinette Chatre
Date: Wed Nov 30 2022 - 11:34:10 EST


Hi Shaopeng,

On 11/30/2022 12:32 AM, Shaopeng Tan (Fujitsu) wrote:

> Removing ctrl_handler() is only part of the fix in the next version(v5).
> All fixes as follows.
>
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -98,12 +98,17 @@ void cat_test_cleanup(void)
> remove(RESULT_FILE_NAME2);
> }
>
> +static void ctrlc_handler_child(int signum, siginfo_t *info, void *ptr)
> +{
> + exit(EXIT_SUCCESS);
> +}
> +

Could you please elaborate why this is necessary?

Reinette