Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

From: Johannes Berg
Date: Thu Dec 01 2022 - 04:29:10 EST


On Thu, 2022-12-01 at 11:22 +0200, Leon Romanovsky wrote:
>
> > +++ b/drivers/infiniband/hw/qib/Kconfig
> > @@ -3,6 +3,7 @@ config INFINIBAND_QIB
> > tristate "Intel PCIe HCA support"
> > depends on 64BIT && INFINIBAND_RDMAVT
> > depends on PCI
> > + depends on !UML
>
> I would advocate to add this line to whole drivers/infiniband.
> None of RDMA code makes sense for UML.
>

You could argue that one might want to eventually use kunit for some
bits and pieces in there, so it'd make sense to be able to build the
parts that _can_ be built, but I have no idea :)

johannes