Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu.

[Sudeep Holla]

On Thu, Dec 01, 2022 at 03:08:33PM +0800, Wang Honghui wrote:
> Add to support Phytium FT2000/4 CPUs, show temperature of cpu.
> 
> Signed-off-by: Wang Honghui <honghui.wang@xxxxxxxxxxx>
> ---
>  drivers/firmware/arm_scpi.c       |   1 +
>  drivers/mailbox/Kconfig           |   6 +
>  drivers/mailbox/Makefile          |   2 +
>  drivers/mailbox/phytium_mailbox.c | 193 ++++++++++++++++++++++++++++++
>  4 files changed, 202 insertions(+)
>  create mode 100644 drivers/mailbox/phytium_mailbox.c
> 
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 435d0e2658a4..876eb2f9ff81 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -904,6 +904,7 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {
>  	{ .compatible = "amlogic,meson-axg-scp-shmem", },
>  	{ .compatible = "arm,juno-scp-shmem", },
>  	{ .compatible = "arm,scp-shmem", },
> +	{ .compatible = "phytium,ft2004-scpi-shmem", },


Where is the binding for this new compatible ?
And why do you need this ? Any particular reason why you can't use the
generic "arm,scp-shmem" ?

I don't see the need for this change. Please drop it.

--
Regards,
Sudeep