Re: [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon

From: Ulf Hansson
Date: Thu Dec 01 2022 - 05:48:58 EST


On Thu, 1 Dec 2022 at 02:26, <zhang.songyi@xxxxxxxxxx> wrote:
>
> From: zhang songyi <zhang.songyi@xxxxxxxxxx>
>
> The semicolon after the "}" is unneeded.
>
> Signed-off-by: zhang songyi <zhang.songyi@xxxxxxxxxx>

Please run checkpatch (./scripts/checkpatch.pl) to make sure there are
no obvious formatting problems with your patch. This time it gives the
below warning, please fix it and resubmit a new version.

WARNING: please, no spaces at the start of a line
#79: FILE: drivers/mmc/host/sdhci.c:2292:
+ }$

total: 0 errors, 1 warnings, 8 lines checked

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 42aaeabcad22..8413180a1039 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
> case MMC_TIMING_UHS_DDR50:
> case MMC_TIMING_MMC_DDR52:
> return true;
> - };
> + }
> return false;
> }
>
> --
> 2.15.2