Re: Re:Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu.
From: Sudeep Holla
Date: Thu Dec 01 2022 - 06:41:28 EST
On Thu, Dec 01, 2022 at 06:41:46PM +0800, 王洪辉 wrote:
> In DTS of FT2000/4 passed from uboot. Add the DTS file to kernel?
>
No, I was referring to the binding not the DTS file like
Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> Of course, it's also a good way to modify DTS file built in uboot.
>
You need to add the binding to make use of this new compatible in the driver.
And when you add, the first question I have is why you need new compatible
or why you can't use the generic one. If you have valid reasons for that,
then we can add the driver change along with the binding. Please split the
binding that you are about to add and the SCPI driver changes separate from
the mailbox driver changes in this patch.
--
Regards,
Sudeep