Re: [PATCH linux-next] pxa: Remove dev_err() after platform_get_irq()
From: Arnd Bergmann
Date: Thu Dec 01 2022 - 10:33:28 EST
On Wed, Nov 30, 2022, at 08:56, zhang.songyi@xxxxxxxxxx wrote:
> From: zhang songyi <zhang.songyi@xxxxxxxxxx>
>
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> /drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: zhang songyi <zhang.songyi@xxxxxxxxxx>
> ---
> drivers/soc/pxa/ssp.c | 1 -
> 1 file changed, 1 deletion(-)
I tried to apply the patch, but it appears to be whitespace damaged
and does not apply, probably something wrong with your email client.
Can you make sure you are following the steps in
Documentation/translations/zh_CN/process/email-clients.rst and
resend the patch, with Lubomir's Reviewed-by added in?
Usually the process it for platform maintainers to pick up patches,
but this time please send it directly to soc@xxxxxxxxxx (since
there is already maintainer ack) and I'll pick it up from there.
Thanks,
Arnd