Re: [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC

From: Krzysztof Kozlowski
Date: Thu Dec 01 2022 - 11:17:11 EST


On 01/12/2022 05:46, Saravanan Sekar wrote:
> Document mpq7932 power-management IC
>
> Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx>
> ---
> .../bindings/hwmon/pmbus/mps,mpq7932.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml
> new file mode 100644
> index 000000000000..5f20c59eb7ff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/mps,mpq7932.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power System MPQ7932 PMIC
> +
> +maintainers:
> + - Saravanan Sekar <saravanan@xxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - mps,mpq7932
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + type: object

The comment was - drop regulators node if you have just one regulator...
but it turns out you have more regulators? Then you need to follow
regulator bindings. Open few and take a look.

> +
> + description: |
> + list of regulators provided by this controller, must be named
> + after their hardware counterparts BUCK[1-6]
> +

This misses patternProperties.

> + "^buck[1-6]$":
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - regulators
> +
> +additionalProperties: false


Best regards,
Krzysztof