Coverity: kvm_hv_flush_tlb(): Uninitialized variables
From: coverity-bot
Date: Thu Dec 01 2022 - 11:25:49 EST
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221201 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Fri Nov 18 12:59:05 2022 -0500
260970862c88 ("KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls gently")
Coverity reported the following:
*** CID 1527764: Uninitialized variables (UNINIT)
arch/x86/kvm/hyperv.c:2024 in kvm_hv_flush_tlb()
2018 * Hyper-V TLFS doesn't explicitly forbid non-empty sparse vCPU
2019 * banks (and, thus, non-zero 'var_cnt') for the 'all vCPUs'
2020 * case (HV_GENERIC_SET_ALL). Always adjust data_offset and
2021 * consumed_xmm_halves to make sure TLB flush entries are read
2022 * from the correct offset.
2023 */
vvv CID 1527764: Uninitialized variables (UNINIT)
vvv Using uninitialized value "data_offset".
2024 data_offset += hc->var_cnt * sizeof(sparse_banks[0]);
2025 consumed_xmm_halves += hc->var_cnt;
2026 }
2027
2028 if (hc->code == HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE ||
2029 hc->code == HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX ||
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
Addresses-Coverity-ID: 1527764 ("Uninitialized variables")
Fixes: 260970862c88 ("KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls gently")
Thanks for your attention!
--
Coverity-bot