Re: [PATCH] net: microchip: sparx5: Fix missing destroy_workqueue of mact_queue

[Pavan Chebbi]

On Thu, Dec 1, 2022 at 6:57 PM Qiheng Lin <linqiheng@xxxxxxxxxx> wrote:
>
> The mchp_sparx5_probe() won't destroy workqueue created by
> create_singlethread_workqueue() in sparx5_start() when later
> inits failed. Add destroy_workqueue in the cleanup_ports case,
> also add it in mchp_sparx5_remove()
>
> Signed-off-by: Qiheng Lin <linqiheng@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> index eeac04b84638..b6bbb3c9bd7a 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> @@ -887,6 +887,8 @@ static int mchp_sparx5_probe(struct platform_device *pdev)
>
>  cleanup_ports:
>         sparx5_cleanup_ports(sparx5);
> +       if (sparx5->mact_queue)
> +               destroy_workqueue(sparx5->mact_queue);

Would be better if you destroy inside sparx5_start() before returning failure.

>  cleanup_config:
>         kfree(configs);
>  cleanup_pnode:
> @@ -911,6 +913,7 @@ static int mchp_sparx5_remove(struct platform_device *pdev)
>         sparx5_cleanup_ports(sparx5);
>         /* Unregister netdevs */
>         sparx5_unregister_notifier_blocks(sparx5);
> +       destroy_workqueue(sparx5->mact_queue);
>
>         return 0;
>  }
> --
> 2.32.0
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature