Re: [PATCH 5.10 000/162] 5.10.157-rc1 review

[Greg Kroah-Hartman]

On Fri, Dec 02, 2022 at 12:49:09PM +0100, Pavel Machek wrote:
> Hi!
> 
> [If I cc-ed you, you are author of one of patches below. Please take a
> look.]
> 
> > Responses should be made by Fri, 02 Dec 2022 18:05:05 +0000.
> > Anything received after that time might be too late.
> 
> I hope to make it :-). I
> 
> > Pawel Laszczak <pawell@xxxxxxxxxxx>
> >     usb: cdnsp: Device side header file for CDNSP driver
> > 
> > Pawel Laszczak <pawell@xxxxxxxxxxx>
> >     usb: cdns3: Add support for DRD CDNSP
> 
> These two together are 1500+ lines, and are marked as Stable-dep-of:
> 9d5333c93134 ("usb: cdns3: host: fix endless superspeed hub port
> reset") . But we don't have that one in 5.10 tree. Likely we should
> not have these either.

I already dropped these yesterday.

> > Maxim Levitsky <mlevitsk@xxxxxxxxxx>
> >     KVM: x86: emulator: update the emulation mode after rsm
> 
> No. The patch does not do anything. Mainline commit this referenced
> changed the return value, this changes just a comment. Wrong backport?

I will look at this.

> > Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> >     speakup: Generate speakupmap.h automatically
> 
> Ok, so this one rewrites some header generation and is buggy. 500+ lines.

Already dropped yesterday.

> > Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx>
> >     speakup: replace utils' u_char with unsigned char
> 
> With this patch fixing it. The rewrite is marked as stable depedncency
> of the fix, but fix would not be needed if we did not apply the
> rewrite. We should not have these two in stable.

Again, already dropped.

thanks for the review.

greg k-h