Coverity: mt7915_rate_txpower_get(): Resource leaks

From: coverity-bot
Date: Fri Dec 02 2022 - 17:26:21 EST


Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221202 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

Thu Dec 1 17:29:14 2022 +0100
bd2404d42821 ("wifi: mt76: mt7915: add basedband Txpower info into debugfs")

Coverity reported the following:

*** CID 1527799: Resource leaks (RESOURCE_LEAK)
drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:999 in mt7915_rate_txpower_get()
993 buf = kzalloc(sz, GFP_KERNEL);
994 if (!buf)
995 return -ENOMEM;
996
997 ret = mt7915_mcu_get_txpower_sku(phy, txpwr, sizeof(txpwr));
998 if (ret)
vvv CID 1527799: Resource leaks (RESOURCE_LEAK)
vvv Variable "buf" going out of scope leaks the storage it points to.
999 return ret;
1000
1001 /* Txpower propagation path: TMAC -> TXV -> BBP */
1002 len += scnprintf(buf + len, sz - len,
1003 "\nPhy%d Tx power table (channel %d)\n",
1004 phy != &dev->phy, phy->mt76->chandef.chan->hw_value);

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
Addresses-Coverity-ID: 1527799 ("Resource leaks")
Fixes: bd2404d42821 ("wifi: mt76: mt7915: add basedband Txpower info into debugfs")

Thanks for your attention!

--
Coverity-bot