Re: [PATCH net-next v1 3/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings

[Michael Walle]

Am 2022-12-02 19:31, schrieb Andrew Lunn:
> On Fri, Dec 02, 2022 at 04:12:03PM +0100, Michael Walle wrote:
> > Add the device tree bindings for the MaxLinear GPY2xx PHYs.
> >
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
> > ---
> >
> > Is the filename ok? I was unsure because that flag is only for the 
> > GPY215
> > for now. But it might also apply to others. Also there is no 
> > compatible
> > string, so..
> >
> >  .../bindings/net/maxlinear,gpy2xx.yaml        | 47 
> > +++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml 
> > b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> > new file mode 100644
> > index 000000000000..d71fa9de2b64
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/maxlinear,gpy2xx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MaxLinear GPY2xx PHY
> > +
> > +maintainers:
> > +  - Andrew Lunn <andrew@xxxxxxx>
> > +  - Michael Walle <michael@xxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: ethernet-phy.yaml#
> > +
> > +properties:
> > +  maxlinear,use-broken-interrupts:
> > +    description: |
> > +      Interrupts are broken on some GPY2xx PHYs in that they keep the
> > +      interrupt line asserted even after the interrupt status 
> > register is
> > +      cleared. Thus it is blocking the interrupt line which is 
> > usually bad
> > +      for shared lines. By default interrupts are disabled for this 
> > PHY and
> > +      polling mode is used. If one can live with the consequences, 
> > this
> > +      property can be used to enable interrupt handling.
> > +
> > +      Affected PHYs (as far as known) are GPY215B and GPY215C.
> > +    type: boolean
> > +
> > +dependencies:
> > +  maxlinear,use-broken-interrupts: [ interrupts ]
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    ethernet {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ethernet-phy@0 {
> > +            reg = <0>;
> > +            interrupts-extended = <&intc 0>;
> > +            maxlinear,use-broken-interrupts;
> > +        };
> > +    };
>
> I'm wondering if we want this in the example. We probably don't want
> people to use this property by accident, i.e. copy/paste without
> reading the rest of the document. This will becomes a bigger problem
> if more properties are added, RGMII delays etc.
>
> So maybe just skip the example?

I agree. Let's wait what the device tree maintainers say.

-michael