Re: [PATCH v4 01/39] Documentation/x86: Add CET shadow stack description

[Bagas Sanjaya]

On Fri, Dec 02, 2022 at 04:35:28PM -0800, Rick Edgecombe wrote:
> +An application's CET capability is marked in its ELF note and can be verified
> +from readelf/llvm-readelf output:
> +
> +    readelf -n <application> | grep -a SHSTK
> +        properties: x86 feature: SHSTK

Shell commands should be inside literal code block (try double colon).
Above is rendered as definition lists instead.

> +The return values are as following:
> +    On success, return 0. On error, errno can be::

Drop indentation on the second line, or better yet, continue the line,
like "... as following. On success, ..."

Otherwise LGTM, thanks for review. 

In any case,

Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>

-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature